Conditions | 3 |
Total Lines | 64 |
Code Lines | 60 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | import React, { Fragment } from "react" |
||
74 | renderTeamStats = () => { |
||
75 | if (this.state.loading === false && this.state.data) { |
||
76 | const { extraStats } = this.state.data |
||
77 | return ( |
||
78 | <Card |
||
79 | className={"team_stats__team"} |
||
80 | title="Statistieken" |
||
81 | > |
||
82 | <span className={"team_stats__label"}>Gespeeld</span> |
||
83 | <span>{extraStats.gamesPlayed}</span> |
||
84 | <span className={"team_stats__label"}>Gewonnen</span> |
||
85 | <span>{extraStats.gamesWon}</span> |
||
86 | <span className={"team_stats__label"}>Gelijk</span> |
||
87 | <span>{extraStats.gamesEqual}</span> |
||
88 | <span className={"team_stats__label"}>Verloren</span> |
||
89 | <span>{extraStats.gamesLost}</span> |
||
90 | <span className={"team_stats__label"}>Doelpunten</span> |
||
91 | <span> |
||
92 | {extraStats.goalsScored} voor / {extraStats.goalsAgainst} tegen |
||
93 | </span> |
||
94 | <span className={"team_stats__label"}>Cleansheets</span> |
||
95 | <span>{extraStats.cleanSheets}</span> |
||
96 | <span className={"team_stats__label"}>Gele kaarten</span> |
||
97 | <span>{extraStats.yellowCards}</span> |
||
98 | <span className={"team_stats__label"}>Rode kaarten</span> |
||
99 | <span>{extraStats.redCards}</span> |
||
100 | <span className={"team_stats__label"}>Wedstrijden niet gescoord</span> |
||
101 | <span>{extraStats.notScored}</span> |
||
102 | <span className={"team_stats__label"}>Grootste overwinning</span> |
||
103 | <span> |
||
104 | {extraStats.biggestWin.result} tegen{" "} |
||
105 | {extraStats.biggestWin.opponent} |
||
106 | </span> |
||
107 | <span className={"team_stats__label"}>Grootste verlies</span> |
||
108 | <span> |
||
109 | {extraStats.biggestLoss.result} tegen{" "} |
||
110 | {extraStats.biggestLoss.opponent} |
||
111 | </span> |
||
112 | <span className={"team_stats__label"}>Meeste doelpunten</span> |
||
113 | <span> |
||
114 | {extraStats.mostGoals.result} tegen {extraStats.mostGoals.opponent} |
||
115 | </span> |
||
116 | <span className={"team_stats__label"}>Topschutters</span> |
||
117 | <ul className={"team_stats__list"}> |
||
118 | {extraStats.topscorers |
||
119 | .sort((a, b) => b.value - a.value) |
||
120 | .map((player, i) => ( |
||
121 | <li key={i}> |
||
122 | {player.firstName} {player.lastName} ({player.value}) |
||
123 | </li> |
||
124 | ))} |
||
125 | </ul> |
||
126 | <span className={"team_stats__label"}>Laatste wedstrijden</span> |
||
127 | <span> |
||
128 | {extraStats.gameStreak.map((game, i) => ( |
||
129 | <span |
||
130 | className={`team_stats__streak team_stats__streak--${game.result.toLowerCase()}`} |
||
131 | title={`${translateGameResult(game.result)}`} |
||
132 | > |
||
133 | {game.result.charAt(0) !== "E" ? game.result.charAt(0) : "D"} |
||
134 | </span> |
||
135 | ))} |
||
136 | </span> |
||
137 | </Card> |
||
138 | ) |
||
285 |